Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope down unsafe currency usage #356

Closed
wants to merge 1 commit into from
Closed

scope down unsafe currency usage #356

wants to merge 1 commit into from

Conversation

elfassy
Copy link
Contributor

@elfassy elfassy commented Jan 28, 2025

Why

rather than a config that applies to the whole repo, this will allow us to go case by case and remove the outstanding legacy behaviour

What

In both cases a deprecation warning will be generated

# before

Money.config.legacy_deprecations! # can still be used for other deprecations than cross-currency

# after

Money.unsafe { money1 + money2 }

rather than a config that applies to the whole repo, this will allow us to go case by case and remove the outstanding legacy behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant