Expose Run Id to Task Instance #1112
Open
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenprater
force-pushed
the
expose-run-id-to-task
branch
from
7e519af to
2ab5ab0
Compare
Comment on lines
116
to
+117
| @task = @run.task | ||
| @task.run_id = @run.id |
There was a problem hiding this comment.
We should fold this in Run#task. It should go in Task#initialize. We just need to make sure we can still do MaintenanceTasks::Task.new without an argument, because that's used a lot for testing (e.g. Maintenance::SomeTask.collection). Also it should be a keyword argument.
| @@ -29,6 +29,8 @@ class NotFoundError < NameError; end | |||
|
|
|||
| define_callbacks :start, :complete, :error, :cancel, :pause, :interrupt | |||
|
|
|||
| attr_accessor :run_id | |||
There was a problem hiding this comment.
Suggested change
| attr_accessor :run_id | |
| attr_reader :run_id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Run record contains a lot of information that's interesting to a Task, including
metadata, the id, the status of the run, etc.
It's been previously rejected to expose the whole instance of the Run on the Task, so
in this case we're exposing only the ID. That gives us a unique identifier for the
execution of a given Task instance, without tying it explicitly to the Run object, but
also allowing interested parties to fetch that information if they so desire.