Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest temp file to gitignore #2637

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Nov 7, 2024

WHY are these changes introduced?

When running npm run test:watch the file packages/hydrogen-codegen/tsconfig.vitest-temp.json is created each time and should not be committed.

WHAT is this pull request doing?

Ignores any tsconfig.vitest-temp.json files that are created within the repository.

HOW to test your changes?

Run npm run test:watch, confirm that there is no file packages/hydrogen-codegen/tsconfig.vitest-temp.json appearing in unstaged changes.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes N/A
  • I've added tests to cover my changes N/A
  • I've added or updated the documentation N/A

@wizardlyhel wizardlyhel merged commit 0aced0f into Shopify:main Nov 26, 2024
6 checks passed
@lb- lb- deleted the cleanup/add-vitest-temp-to-gitignore branch November 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants