Add support for new combination options #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoffbeck
reviewed
Aug 3, 2023
src/stories/patterns/CombinationCardPattern/CombinationCardPattern.stories.tsx
Outdated
Show resolved
Hide resolved
lhoffbeck
reviewed
Aug 3, 2023
src/stories/patterns/CombinationCardPattern/CombinationCardPattern.tsx
Outdated
Show resolved
Hide resolved
lhoffbeck
approved these changes
Aug 3, 2023
davejcameron
force-pushed
the
update-combines-with
branch
from
617a261
to
d6e2f82
Compare
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| "warning": { | ||
| "title": "Some combinations can result in large discounts", | ||
| "description": "Test a few combinations. If the total discount is too large, adjust which discounts can combine.", | ||
| "link": "Learn more" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Learn morefor keyDiscountAppComponents.CombinationCard.warning.linkis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
Add in the warning banner
davejcameron
force-pushed
the
update-combines-with
branch
from
6f01354
to
31ee8cc
Compare
mathiusj
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
Adds support for the new combination options that are available here: https://help.shopify.com/en/manual/discounts/combining-discounts/discount-combinations#discount-combination-examples