Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to polaris 11 and React 18.2.0 #77

Merged
merged 2 commits into from
Jul 20, 2023
Merged

chore: upgrade to polaris 11 and React 18.2.0 #77

merged 2 commits into from
Jul 20, 2023

Conversation

mathiusj
Copy link
Contributor

@mathiusj mathiusj commented Jul 19, 2023 •
edited
Loading

Description

This version bump is required to align the package with upcoming work that also uses Polaris 11 and fails to install, as well as unblocking external devs from their own development.

Explanation of Changes

  • Polaris and React version bumps with respective dependencies
  • Polaris components renaming to temporarily use Legacy components
  • Updates a few tests that were failing after version bump

Tophat Instructions

  • dev up to build the package
  • npm run storybook
  • Check components in storybook to ensure nothing crashes or seems out of sorts

@mathiusj mathiusj mentioned this pull request Jul 19, 2023
Closed
@mathiusj mathiusj force-pushed the mathiusj/bump-polaris-react branch from a3ae6d7 to 03025b4 Compare July 19, 2023 22:14
@mathiusj mathiusj changed the title chore: upgrade to polaris 11 and react 18 chore: upgrade to polaris 11 Jul 19, 2023
@mathiusj mathiusj force-pushed the mathiusj/bump-polaris-react branch from 75bebbc to c323322 Compare July 19, 2023 22:44
@mathiusj mathiusj changed the title chore: upgrade to polaris 11 chore: upgrade to polaris 11 and React 18.2.0 Jul 19, 2023
aeperea
aeperea requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@aeperea aeperea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran npm run storybook and most of the components are not rendering:
https://screenshot.click/20-06-yke7i-j1zuv.mp4

@aeperea
Copy link
Contributor

aeperea commented Jul 20, 2023

I ran npm run storybook and most of the components are not rendering: https://screenshot.click/20-06-yke7i-j1zuv.mp4

I had to do an node version upgrade and dev up and it worked 😅

@aeperea aeperea self-requested a review July 20, 2023 15:23
aeperea
aeperea approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@aeperea aeperea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AronZeng
Copy link

Not a FED expert but lgtm and tophat looks good.

@AronZeng AronZeng self-requested a review July 20, 2023 19:18
@mathiusj mathiusj merged commit a7992bd into main Jul 20, 2023
4 checks passed
@mathiusj mathiusj deleted the mathiusj/bump-polaris-react branch July 20, 2023 19:20
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeperea aeperea aeperea approved these changes

@AronZeng AronZeng AronZeng approved these changes

@lhoffbeck lhoffbeck Awaiting requested review from lhoffbeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiusj @aeperea @AronZeng