fix: revert to non-shopify job for cla workflow #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
the CLA workflow was failing to lookup IP addresses initially, and it seemed like the right approach was to use shopify-ubuntu-latest based on some threads in slack. This appears to have made it worse (the runner is not found at all for the workflow), which I am now seeing in a discourse thread we should not be using this workflow runner in public repos >.<
https://discourse.shopify.io/t/ip-address-restriction-error-for-cla-workflow-with-public-github-repos/40836/6
original commit: 0dd2f5a
Reviewers’ hat-rack 🎩
Before requesting reviews
Before you deploy