Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations: #154 #163

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Update translations: #154 #163

merged 4 commits into from
Oct 3, 2023

Conversation

translation-platform[bot]
Copy link
Contributor

This PR adds async translations requested in #154, which was opened by @mathiusj.

It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in.

Check the source PR's overall translation progress here.

Before you deploy

  • Check translations for malicious HTML.

Merge conflicts?

If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order:

  1. Close this PR.
  2. Run the following Spy command in Slack:

@spy translation-platform force-pull Shopify/discount-app-components pull_request_number=154

Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR.

Missing completed translations?

If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise).

If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR:

@spy translation-platform force-pull Shopify/discount-app-components pull_request_number=154

  • The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped.
  • A later change to the translation files might have overwritten the previously downloaded translations.
  • Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below.

Questions?

Visit #help-localization for questions about this pull request.

@github-actions
Copy link
Contributor

Hello and thank you for your contribution! Before we can merge your pull request, we ask that you create a changeset to describe your changes. This will help us manage versions and release notes. You can create a changeset by running yarn changeset in your terminal. You can find more information about our contribution guidelines here. Thank you again!

@translation-platform
Copy link
Contributor Author

🕐 This Pull Request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

It is your responsibility to shipit/merge this PR once you've reviewed it. 🙏

💚

@mathiusj mathiusj merged commit af62b07 into main Oct 3, 2023
5 checks passed
@mathiusj mathiusj deleted the translation-platform/pr/154 branch October 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant