Fix test

Shopify · Aug 3, 2023 · 3fdd6bf · 3fdd6bf
1 parent c7400dd
commit 3fdd6bf
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/src/components/CombinationCard/tests/CombinationCard.test.tsx b/src/components/CombinationCard/tests/CombinationCard.test.tsx
@@ -265,16 +265,16 @@ describe('<CombinationCard />', () => {
   });
 
   it.each`
-    discountClass             | selectedChoices            | shouldShowBanner
-    ${DiscountClass.Order}    | ${['PRODUCT']}             | ${true}
-    ${DiscountClass.Order}    | ${['ORDER']}               | ${true}
-    ${DiscountClass.Order}    | ${['SHIPPING']}            | ${false}
-    ${DiscountClass.Product}  | ${['ORDER']}               | ${true}
-    ${DiscountClass.Product}  | ${['PRODUCT', 'SHIPPING']} | ${false}
-    ${DiscountClass.Shipping} | ${['PRODUCT', 'ORDER']}    | ${false}
+    discountClass             | selectedChoices            | bannerCount
+    ${DiscountClass.Order}    | ${['PRODUCT']}             | ${1}
+    ${DiscountClass.Order}    | ${['ORDER']}               | ${1}
+    ${DiscountClass.Order}    | ${['SHIPPING']}            | ${0}
+    ${DiscountClass.Product}  | ${['ORDER']}               | ${1}
+    ${DiscountClass.Product}  | ${['PRODUCT', 'SHIPPING']} | ${0}
+    ${DiscountClass.Shipping} | ${['PRODUCT', 'ORDER']}    | ${0}
   `(
     'renders warning banner conditionally for $discountClass discount and selected choices $selectedChoices',
-    ({discountClass, selectedChoices, shouldShowBanner}) => {
+    ({discountClass, selectedChoices, bannerCount}) => {
       const mockPropsWithSelectedChoices = {
         ...mockProps,
         discountClass,
@@ -289,11 +289,7 @@ describe('<CombinationCard />', () => {
         <CombinationCard {...mockPropsWithSelectedChoices} />,
       );
 
-      if (shouldShowBanner) {
-        expect(combinationCard).toContainReactComponent(Banner);
-      } else {
-        expect(combinationCard).not.toContainReactComponent(Banner);
-      }
+      expect(combinationCard.findAll(Banner)).toHaveLength(bannerCount);
     },
   );
 });