New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `shopify theme package` to support theme blocks #5139

Open

montalvomiguelo wants to merge 2 commits into Shopify:main from montalvomiguelo:theme-package-blocks

Contributor

montalvomiguelo commented Dec 22, 2024

WHY are these changes introduced?

Fixes #5135

WHAT is this pull request doing?

Updates shopify theme package to support theme blocks.

How to test your changes?

Download https://github.com/Shopify/reference-theme
Run shopify theme package --path ~/Downloads/reference-theme
Notice the zip file includes theme blocks

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes

montalvomiguelo added 2 commits

December 22, 2024 16:58


          Allow packaging theme blocks

3b3cc3d


          Add release note

7b9f887

montalvomiguelo requested review from a team as code owners

December 22, 2024 23:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet