-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record business_platform_id not partner_id in remaining cases #5138
base: make-organization-source-required
Are you sure you want to change the base?
Record business_platform_id not partner_id in remaining cases #5138
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1994 tests passing in 900 suites. Report generated by 🧪jest coverage report action from 4861084 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
9ebb294
to
e746586
Compare
c2c710a
to
4a65bd2
Compare
4a65bd2
to
4861084
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/monorail.d.ts@@ -16,6 +16,7 @@ export interface Schemas {
env_plugin_installed_all?: Optional<string>;
};
public: {
+ business_platform_id?: Optional<number>;
partner_id?: Optional<number>;
command: string;
project_type?: Optional<string>;
packages/cli-kit/dist/public/node/plugins.d.ts@@ -16,7 +16,7 @@ import { Config, Interfaces } from '@oclif/core';
* @returns A dictionary of plug-in names to the response from the hook.
*/
export declare function fanoutHooks<TPluginMap extends HookReturnsPerPlugin, TEvent extends string & keyof TPluginMap>(config: Interfaces.Config, event: TEvent, options: TPluginMap[typeof event]['options'], timeout?: number): Promise<Partial<TPluginMap[typeof event]['pluginReturns']>>;
-type AppSpecificMonorailFields = PickByPrefix<MonorailEventPublic, 'app_', 'project_type' | 'api_key' | 'partner_id'> & PickByPrefix<MonorailEventPublic, 'cmd_extensions_'> & PickByPrefix<MonorailEventPublic, 'cmd_scaffold_'>;
+type AppSpecificMonorailFields = PickByPrefix<MonorailEventPublic, 'app_', 'project_type' | 'api_key' | 'partner_id' | 'business_platform_id'> & PickByPrefix<MonorailEventPublic, 'cmd_extensions_'> & PickByPrefix<MonorailEventPublic, 'cmd_scaffold_'>;
type AppSpecificSensitiveMonorailFields = PickByPrefix<MonorailEventSensitive, 'app_'>;
export interface HookReturnsPerPlugin extends HookReturnPerTunnelPlugin {
public_command_metadata: {
|
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2025
Prerequisite here
WHAT is this pull request doing?
How to test your changes?
shopify app env pull
with both Partners and Business Platform appsshopify app info
with both Partners and Business Platform appsMeasuring impact
Checklist