Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt to gitignore #5121

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add wasm-opt to gitignore #5121

merged 1 commit into from
Jan 6, 2025

Conversation

andrewhassan
Copy link
Contributor

@andrewhassan andrewhassan commented Dec 17, 2024

WHY are these changes introduced?

The wasm-opt.cjs file is not included in the gitignore, but it shouldn't be committed.

WHAT is this pull request doing?

This PR adds wasm-opt to the gitignore.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.23% (-0.01% 🔻)
8805/11704
🟡 Branches 70.55% 4278/6064
🟡 Functions 75.02% 2304/3071
🟡 Lines 75.77% 8323/10984
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% 90.48% 98.61%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1987 tests passing in 898 suites.

Report generated by 🧪jest coverage report action from 81623c4

@andrewhassan andrewhassan requested a review from shauns December 17, 2024 18:16
@andrewhassan andrewhassan marked this pull request as ready for review January 3, 2025 22:04
@andrewhassan andrewhassan requested a review from a team as a code owner January 3, 2025 22:04
@shauns shauns added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 99b55c0 Jan 6, 2025
26 checks passed
@shauns shauns deleted the ah.gitignore-wasm-opt branch January 6, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants