Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflows for extensions that have related extensions #5108

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

devisscher
Copy link

@devisscher devisscher commented Dec 13, 2024

Hack Days 37 POC

@devisscher devisscher marked this pull request as ready for review December 13, 2024 15:14
@devisscher devisscher requested a review from a team as a code owner December 13, 2024 15:14
Copy link
Author

devisscher commented Dec 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Unused exports (1)

Filename exports
packages/app/src/cli/prompts/generate/extension.ts promptAddExtensionConfirmation

Unused types (1)

Filename types
packages/app/src/cli/services/generate/workflows/patch-configuration-file.ts PatchTomlOptions

Duplicates (2)

Filename duplicates
packages/app/src/cli/prompts/generate/extension.ts generateExtensionPrompts, default

@devisscher devisscher changed the title Start taking notes Improve workflows for extensions that have related extensions Dec 13, 2024
@nickwesselman
Copy link
Contributor

/snapit

Copy link
Contributor

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@nickwesselman nickwesselman requested review from a team and jacobsteves and removed request for a team and jacobsteves December 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants