Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Add TODOs for template generator improvements #5101

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[Themes] Add TODOs for template generator improvements #5101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/theme/src/cli/services/generate/sections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import {joinPath} from '@shopify/cli-kit/node/path'
import {outputInfo} from '@shopify/cli-kit/node/output'

export interface SectionGeneratorOptions {

Check failure on line 6 in packages/theme/src/cli/services/generate/sections.ts

View workflow job for this annotation

GitHub Actions / knip-reporter-annotations-check

packages/theme/src/cli/services/generate/sections.ts#L6 

'SectionGeneratorOptions' is an unused type
name: string
path: string
fileType: FileType
Expand All @@ -19,6 +19,8 @@
* ------------------------------------------------------------
*/`

// TODO: move name / path resolution logic upstream

Check failure on line 22 in packages/theme/src/cli/services/generate/sections.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/theme/src/cli/services/generate/sections.ts#L22 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: move name / path resolution logic...'.
// TODO: Rather than throwing an error here we should prompt for name upstream

Check failure on line 23 in packages/theme/src/cli/services/generate/sections.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/theme/src/cli/services/generate/sections.ts#L23 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Rather than throwing an error here...'.
export async function generateSection(options: SectionGeneratorOptions) {
const sectionPath = joinPath(options.path, 'sections', `${options.name}.${options.fileType}`)

Expand Down
2 changes: 2 additions & 0 deletions packages/theme/src/cli/services/generate/templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
import {joinPath} from '@shopify/cli-kit/node/path'
import {outputInfo} from '@shopify/cli-kit/node/output'

// TODO: move name / path resolution logic upstream

Check failure on line 6 in packages/theme/src/cli/services/generate/templates.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/theme/src/cli/services/generate/templates.ts#L6 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: move name / path resolution logic...'.
// TODO: add type flag

Check failure on line 7 in packages/theme/src/cli/services/generate/templates.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/theme/src/cli/services/generate/templates.ts#L7 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: add type flag'.
export interface TemplateGeneratorOptions {

Check failure on line 8 in packages/theme/src/cli/services/generate/templates.ts

View workflow job for this annotation

GitHub Actions / knip-reporter-annotations-check

packages/theme/src/cli/services/generate/templates.ts#L8 

'TemplateGeneratorOptions' is an unused type
name: string | undefined
path: string
fileType: FileType
Expand Down
Loading