-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for discount function settings #5096
base: nw-hackdays37-extension-workflow-registry
Are you sure you want to change the base?
Add workflow for discount function settings #5096
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Unused exports (1)
Unused types (1)
Duplicates (2)
|
ffd2c4b
to
54b317e
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -171,19 +171,12 @@ export declare function fileSize(path: string): Promise<number>;
* @returns The size of the file in bytes.
*/
export declare function fileSizeSync(path: string): number;
-/**
- * Synchronously unlink a file at the given path.
- *
- * @param path - Path to the file.
- */
-export declare function unlinkFileSync(path: string): void;
/**
* Unlink a file at the given path.
- *
* @param path - Path to the file.
* @returns A promise that resolves when the file is unlinked.
*/
-export declare function unlinkFile(path: string): Promise<void>;
+export declare function unlinkFileSync(path: string): void;
/**
* Create a read stream for a file with optional options.
*
packages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -15,9 +15,6 @@ export declare const bunLockfile = "bun.lockb";
export declare const pnpmWorkspaceFile = "pnpm-workspace.yaml";
/** An array containing the lockfiles from all the package managers */
export declare const lockfiles: Lockfile[];
-export declare const lockfilesByManager: {
- [key in PackageManager]: Lockfile | undefined;
-};
export type Lockfile = 'yarn.lock' | 'package-lock.json' | 'pnpm-lock.yaml' | 'bun.lockb';
/**
* A union type that represents the type of dependencies in the package.json
packages/cli-kit/dist/public/node/themes/api.d.ts@@ -1,4 +1,3 @@
-import { MetafieldOwnerType } from '../../../cli/api/graphql/admin/generated/types.js';
import { AdminSession } from '@shopify/cli-kit/node/session';
import { Result, Checksum, Key, Theme, ThemeAsset } from '@shopify/cli-kit/node/themes/types';
export type ThemeParams = Partial<Pick<Theme, 'name' | 'role' | 'processing' | 'src'>>;
@@ -12,14 +11,4 @@ export declare function bulkUploadThemeAssets(id: number, assets: AssetParams[],
export declare function fetchChecksums(id: number, session: AdminSession): Promise<Checksum[]>;
export declare function themeUpdate(id: number, params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
export declare function themePublish(id: number, session: AdminSession): Promise<Theme | undefined>;
-export declare function themeDelete(id: number, session: AdminSession): Promise<boolean | undefined>;
-export declare function metafieldDefinitionsByOwnerType(type: MetafieldOwnerType, session: AdminSession): Promise<{
- key: string;
- namespace: string;
- name: string;
- description: string | null | undefined;
- type: {
- name: string;
- category: string;
- };
-}[]>;
\ No newline at end of file
+export declare function themeDelete(id: number, session: AdminSession): Promise<boolean | undefined>;
\ No newline at end of file
|
dd3b1c5
to
7192936
Compare
54b317e
to
87524f5
Compare
87524f5
to
8dfb3bc
Compare
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist