Remove numeric as a required param for Country

Shopify · Jan 14, 2025 · a23b60a · a23b60a
1 parent fb2c3a1
commit a23b60a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/active_utils/country.rb b/lib/active_utils/country.rb
@@ -40,7 +40,7 @@ class Country
     attr_reader :name
 
     def initialize(options = {})
-      requires!(options, :name, :alpha2, :alpha3, :numeric)
+      requires!(options, :name, :alpha2, :alpha3)
       @name = options.delete(:name)
       @codes = options.collect{|k,v| CountryCode.new(v)}
     end

diff --git a/test/unit/country_test.rb b/test/unit/country_test.rb
@@ -84,4 +84,10 @@ def test_qatar_does_not_use_postal_codes
     qatar = Country.find('Qatar')
     refute qatar.uses_postal_codes?
   end
+
+  def test_find_country_without_numeric_code
+    country = Country.find('ASC')
+    assert_equal 'Ascension Island', country.to_s
+    assert_nil country.code(:numeric)
+  end
 end