use scala primitives (e.g. Integer -> Int) #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: minify diff for flatgraph migration
attention with autoconversions around `Option[Int]` and similar: ``` scala> Option(null: Integer) val res0: Option[Integer] = None scala> val o: Option[Int] = Option(null: Integer) val o: Option[Int] = Some(0) scala> val o: Option[Int] = Option(null: Integer).asInstanceOf[Option[Int]] val o: Option[Int] = None ```
scala performs quite some magic to handle Option[Int], and the bytecode looks differently if javac or scalac compile something like `val x: Option[Int]`: ``` // scalac: public static flatgraph.SinglePropertyKey<java.lang.Object> ArgumentIndex(); //javac: public static final overflowdb.PropertyKey<scala.Int> ARGUMENT_INDEX; ``` Hence, the best way forward is to define these constants in scala.
bbrehm
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: minify diff for flatgraph migration