Allow closure bindings on method parameters #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBakerEffendi
added a commit
to joernio/joern
that referenced
this pull request
Nov 7, 2023
The closure bindings for Java lambdas are over-approximated to all variables in the surrounding context. This attempts to constrain this set to variables referenced in the AST body. Note: ShiftLeftSecurity/codepropertygraph#1739 Resolves #3790
DavidBakerEffendi
added a commit
to joernio/joern
that referenced
this pull request
Nov 10, 2023
The closure bindings for Java lambdas are over-approximated to all variables in the surrounding context. This attempts to constrain this set to variables referenced in the AST body. Note: ShiftLeftSecurity/codepropertygraph#1739 Resolves #3790
fabsx00
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for
CLOSURE_BINDINGis: "Represents the binding of a LOCAL or METHOD_PARAMETER_IN into the closure of a method", however there is no edge connecting parameters to theCLOSURE_BINDING. So this adds theCLOSURE_BINDING_IDandCAPTURED_BYedge to match the specification forLOCALnodes.Additionally, the cardinality needs to be changed, since if a method parameter is captured, then there won't be a REF to a local which may throw an error. Thus, cardinality was changed to
ZeroOrOne.