Fixing error handling

[DonKoko]

Progress:

Routes:

• ./api+/user.prefs.upload-user-photo.ts
• ./api+/$organizationId.qr-codes[.zip].ts
• ./api+/public-stats.ts
• ./api+/utils.parse-markdown.ts
• ./api+/user.prefs.dismiss-support-banner.ts
• ./api+/user.prefs.minimized-sidebar.ts
• ./api+/image.$imageId.ts
• ./api+/user.change-current-organization.ts
• ./api+/sse.notification.ts
• ./api+/asset.refresh-main-image.ts
• ./api+/oss-friends.ts
• ./api+/user.prefs.skip-onboarding-checklist.ts
• ./api+/admin.export-org-assets.$organizationId.$fileName[.csv].tsx
• ./api+/admin.import-org-assets.$organizationId.tsx
• ./api+/stripe-webhook.ts
• ./api+/client-notification.ts

---

• ./_welcome+/onboarding.tsx
• ./_welcome+/_layout.tsx
• ./_welcome+/welcome.tsx
• ./_layout+/$.tsx

---

• ./_layout+/settings.tsx
• ./_layout+/assets._index.tsx
• ./_layout+/assets.$assetId.qr.tsx
• ./_layout+/assets.$assetId.give-custody.tsx
• ./_layout+/assets.$assetId.update-location.tsx
• ./_layout+/assets.export.$fileName[.csv].tsx
• ./_layout+/assets.new.tsx
• ./_layout+/assets.$assetId.note.tsx
• ./_layout+/assets.import.tsx
• ./layout+/assets.$assetId.edit.tsx
• ./_layout+/assets.$assetId.duplicate.tsx
• ./_layout+/assets.$assetId.tsx
• ./_layout+/assets.$assetId.release-custody.tsx
• ./_layout+/assets.tsx

---

• ./_layout+/locations.new.tsx
• ./_layout+/locations.$locationId.add-assets.tsx
• ./_layout+/locations.tsx
• ./layout+/locations.$locationId.edit.tsx
• ./_layout+/locations.$locationId.tsx
• ./_layout+/locations._index.tsx

---

• ./_layout+/admin-dashboard+/$userId.tsx
• ./_layout+/admin-dashboard+/org.$organizationId.tsx
• ./_layout+/admin-dashboard+/users.tsx
• ./_layout+/admin-dashboard+/_layout.tsx
• ./_layout+/admin-dashboard+/announcements.tsx
• ./_layout+/admin-dashboard+/announcements.new.tsx

---

• ./_layout+/dashboard.tsx

---

• ./_layout+/bookings.new.tsx
• ./_layout+/bookings.tsx
• ./_layout+/bookings.$bookingId.tsx
• ./_layout+/bookings.$bookingId.add-assets.tsx

---

• ./layout+/settings.custom-fields.$fieldId.edit.tsx
• ./_layout+/settings.general.tsx
• ./_layout+/settings.team.invite-user.tsx
• ./_layout+/settings.custom-fields.index.tsx
• ./_layout+/settings.custom-fields.tsx
• ./_layout+/settings.index.tsx
• ./_layout+/settings.custom-fields.new.tsx
• ./_layout+/settings.team.add-member.tsx

---

• ./_layout+/categories.new.tsx
• ./_layout+/categories.tsx
• ./layout+/categories.$categoryId.edit.tsx

---

• ./_layout+/tags.tsx
• ./layout+/tags.$tagId.edit.tsx
• ./_layout+/tags.new.tsx

---

• ./_layout+/settings.subscription.customer-portal.tsx
• ./_layout+/settings.subscription.tsx
• ./_layout+/settings.team.tsx
• ./_layout+/settings.workspace.tsx
• ./_layout+/settings.workspace.index.tsx
• ./_layout+/settings.workspace.$workspaceId.edit.tsx
• ./_layout+/settings.workspace.new.tsx
• ./_layout+/settings.account.tsx

---

• ./_layout+/_layout.tsx

---

• ./_auth+/login.tsx
• ./_auth+/join.tsx
• ./_auth+/oauth.callback.tsx
• ./_auth+/_auth.tsx
• ./_auth+/logout.tsx
• ./_auth+/send-magic-link.tsx
• ./_auth+/accept-invite.$inviteId.tsx
• ./_auth+/resend-email-confirmation.tsx
• ./_auth+/reset-password.tsx
• ./_auth+/forgot-password.tsx
• ./_auth+/verify-email.tsx

---

• ./healthcheck.tsx

---

• ./qr+/$qrId_.not-logged-in.tsx
• ./qr+/$qrId.tsx
• ./qr+/route.tsx
• ./qr+/$qrId_.contact-owner.tsx
• ./qr+/$qrId_.link.tsx
• ./_index.tsx

Modules

• ./organization/context.server.ts
• ./organization/index.ts
• ./organization/service.server.ts
• ./asset/types.ts
• ./asset/index.ts
• ./asset/service.server.ts
• ./category/index.ts
• ./category/service.server.ts
• ./category/default-categories.ts
• ./auth/session.server.ts
• ./auth/mappers.server.ts
• ./auth/types.ts
• ./auth/components/continue-with-email-form.tsx
• ./auth/components/index.ts
• ./auth/index.ts
• ./auth/service.server.ts
• ./booking/types.ts
• ./booking/email-helpers.ts
• ./booking/constants.ts
• ./booking/index.ts
• ./booking/service.server.ts
• ./booking/worker.server.ts
• ./location/index.ts
• ./location/service.server.ts
• ./custom-field/types.ts
• ./custom-field/index.ts
• ./custom-field/service.server.ts
• ./user/service.server.test.ts
• ./user/types.ts
• ./user/index.ts
• ./user/service.server.ts
• ./qr/utils.server.ts
• ./qr/index.ts
• ./qr/service.server.ts
• ./scan/utils.server.ts
• ./scan/index.ts
• ./scan/service.server.ts
• ./types.ts
• ./invite/helpers.ts
• ./invite/types.ts
• ./invite/index.ts
• ./invite/service.server.ts
• ./team-member/types.ts
• ./team-member/index.ts
• ./team-member/service.server.ts
• ./report-found/index.ts
• ./report-found/service.server.ts
• ./custody/index.ts
• ./custody/service.server.ts
• ./tag/index.ts
• ./tag/service.server.ts
• ./tier/index.ts
• ./tier/service.server.ts

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: All new business logic should have corresponding unit tests.
• Apply: Refactor large functions to be more modular.

[DonKoko]

Not easy to track progress with this task as it affects the whole application and there is plenty to fix.
I have already looked for all the palces where we call new ShelfStackError() and added a comment // @TODO Solve error handling so we can easily track what was solved already.

[DonKoko]

Should Update the Error object to include additionalData such as userId so we can send it to Sentry and have more detailed info about errors.

[DonKoko]

Pausing this as we want to make an improvement where we add userId to additionalData of errors. This is hard to do now and it will be better to do it after we have auth middleware (#467 ).

[DonKoko]

Closing this. It is now tracked in #840