Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handler #346

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Error handler #346

merged 2 commits into from
Sep 15, 2023

Conversation

mahendraHegde
Copy link
Contributor

closes #286

DonKoko
DonKoko previously approved these changes Sep 14, 2023
@DonKoko
Copy link
Contributor

DonKoko commented Sep 14, 2023

@mahendraHegde i checked the code, its all good according to me. Now I just have to refactor a lot of stuff as I want to use try..catch pattern in all our loaders and actions but that will happen one by one.
Can you please fix the eslint, typescript and vitest issues you can see above? Then we merge.

@mahendraHegde
Copy link
Contributor Author

@mahendraHegde i checked the code, its all good according to me. Now I just have to refactor a lot of stuff as I want to use try..catch pattern in all our loaders and actions but that will happen one by one. Can you please fix the eslint, typescript and vitest issues you can see above? Then we merge.

My Bad missed those, fixed alrady.

@DonKoko DonKoko temporarily deployed to external September 14, 2023 15:12 — with GitHub Actions Inactive
@DonKoko DonKoko merged commit 91dbb83 into Shelf-nu:main Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Implement a custom error class
2 participants