Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge #343

Closed
wants to merge 1 commit into from
Closed

do not merge #343

wants to merge 1 commit into from

Conversation

kunal00000
Copy link
Contributor

No description provided.

@kunal00000 kunal00000 temporarily deployed to external September 8, 2023 15:02 — with GitHub Actions Inactive
@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

@kunal00000 this looks better, its just showing the authorize waiting to be done. Shall I approve so we see what runs?

@kunal00000
Copy link
Contributor Author

Yes

@kunal00000
Copy link
Contributor Author

Finally things are working as expected 😌

@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

@kunal00000 I think we have success. I just want to see which error the playwright fails with. If its the SERVER_URL error that means I have to add the vars to that environment in github, if its the other error, thats just the test being broken.

@kunal00000
Copy link
Contributor Author

@kunal00000 I think we have success. I just want to see which error the playwright fails with. If its the SERVER_URL error that means I have to add the vars to that environment in github, if its the other error, thats just the test being broken.

Yes we need to confirm this.

@kunal00000
Copy link
Contributor Author

It worked fine.
It was really interesting issue to work on, learnt alot of things on the go.
Thanks @DonKoko for help through the process.

@kunal00000
Copy link
Contributor Author

closing this now.

@kunal00000 kunal00000 closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants