Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow #342

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix: workflow #342

merged 2 commits into from
Sep 8, 2023

Conversation

kunal00000
Copy link
Contributor

No description provided.

@kunal00000 kunal00000 temporarily deployed to external September 8, 2023 14:39 — with GitHub Actions Inactive
@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

@kunal00000 i had to remove the playwright tests from main branch because of the issue as I couldnt deploy. I think when u made this branch you made it a copy of main so it doesnt have playwright tests. I think you should either enable them in thsi branch to see if it works and if not make a new PR from the previous branch you had, without updating it with main.

@kunal00000
Copy link
Contributor Author

I think it will come if you approve it. I didn't update it with main.

@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

Also I noticed this:
Screenshot 2023-09-08 at 17 43 35

Its not authorized but the tests ran.

Also if you want to know this is how it looks the approval screen:
Screenshot 2023-09-08 at 17 42 52

@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

@kunal00000 I dont know if you can see the same as me so I am sharing:
Screenshot 2023-09-08 at 17 45 26

  1. The tests seem to actually run before authorizing
  2. Can you check if the playwright test is commented out in test.yml file cuz its not showing up here

@kunal00000
Copy link
Contributor Author

Let me figure it out what went wrong.

@kunal00000 kunal00000 changed the title test workflows: do not merge fix: workflow Sep 8, 2023
@kunal00000
Copy link
Contributor Author

@DonKoko can you merge this

@DonKoko DonKoko merged commit ffc4f0e into Shelf-nu:main Sep 8, 2023
3 of 4 checks passed
@DonKoko
Copy link
Contributor

DonKoko commented Sep 8, 2023

@kunal00000 done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants