Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: dynamic select team member for booking form #1408

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Nov 8, 2024

  • Implement DynamicSelect for teamMembers on booking.new
  • Implement DynamicSelect for teamMembers on bookingId(edit view)
  • Specific handling for both BASE and SELF_SERVICE users
  • Remove old CustodianUserSelect component
  • styling of filters column
  • making sure email is shown in all custodian dynamic dropdown and select
  • creating generic function to check if a certain getAll value exists in params: hasGetAllValue
  • Implementing functionality that excludes certain params keys from being stored on asset index cookie, because we should only be storing filtering related params
  • adding and managing pagination for custody, category, location & kit filters on advanced asset index. We will now query 12 by default and use the getAll functionality to get the remaining if the user wishes to do so
  • making sure custodians in dynamic dropdown and select are ordered first by whether they have a user or not and after that alphabetically by name
  • making sure default value of custodian select on booking edit is always set correctly
  • removed a strange label styling that name them all capitalized

- Implement DynamicSelect for teamMembers on booking.new
- Implement DynamicSelect for teamMembers on bookingId(edit view)
- Specific handling for both BASE and SELF_SERVICE users
- Remove old CustodianUserSelect component
@DonKoko DonKoko linked an issue Nov 8, 2024 that may be closed by this pull request
- styling of filters column
- making sure email is shown in all custodian dynamic dropdown and select
- creating generic function to check if a certain getAll value exists in params: hasGetAllValue
- Implementing functionality that excludes certain params keys from being stored on asset index cookie, because we should only be storing filtering related params
- adding and managing pagination for custody, category, location & kit filters on advanced asset index. We will now query 12 by default and use the getAll functionality to get the remaining if the user wishes to do so
- making sure custodians in dynamic dropdown and select are ordered first by whether they have a user or not and after that alphabetically by name
- making sure default value of custodian select on booking edit is always set correctly
- removed a strange label styling that name them all capitalized
@DonKoko DonKoko merged commit a95754d into main Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Searchable and Ordered Custodian in (Admin) Bookings
1 participant