Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow linking of QR codes on import #1319

Merged

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Sep 19, 2024

Resolves #1290

This needs to be tested. It is deployed to staging.
We have quite a few error scenarios. Here is what we are already handling in the code. Let me know if I missed an edge case as that could be.

Error cases to test

  1. Duplicate codes - multiple assets having the same code
  2. Non existent codes - codes that don't exist in shelf
  3. Linked codes - codes that are already linked to an asset or kit
  4. Belonging to other org - codes that are part of other organizations
  5. Empty - doing an import where qrId is added only for some of the assets being imported
  6. No qrId column - when the qrId column is completely missing from the import file.

@DonKoko DonKoko linked an issue Sep 19, 2024 that may be closed by this pull request
4 tasks
@carlosvirreira
Copy link
Contributor

I have tested all cases. For me it can get published.

@DonKoko DonKoko merged commit 457a4a4 into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Allow importing with linking to existing QR code
2 participants