Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to oldest-supported-numpy to support API differences in numpy versions #975

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

jdtuck
Copy link

@jdtuck jdtuck commented Mar 29, 2022

Should really transition to PEP518 and using pyproject.toml, but this will fix #974

@jdtuck
Copy link
Author

jdtuck commented Mar 29, 2022

Let me know if you would like me to just change it over to pyproject.toml. This would fix downstream issues right away.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #975 (68b44f5) into devel (bb1bc50) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #975      +/-   ##
==========================================
- Coverage   54.50%   54.49%   -0.01%     
==========================================
  Files         210      210              
  Lines       21557    21560       +3     
  Branches     3168     3169       +1     
==========================================
  Hits        11750    11750              
- Misses       9253     9255       +2     
- Partials      554      555       +1     

@ekalosak
Copy link
Contributor

Please do the pyproject.toml transition - that's pretty much become the standard, not that I need to tell you @jdtuck .

cc: @lawrennd @apaleyes

@jdtuck
Copy link
Author

jdtuck commented Apr 18, 2022

@ekalosak Just pushed to change to pyproject.toml. Not 100% familiar with all the details of the setup.py, so let me know if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The numpy version in the setup_requires is wrong
2 participants