pep508 dependency specification #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dimbleby
reviewed
Jan 11, 2023
setup.py
Outdated
| 'matplotlib==3.3.4;python_version>="3.6"', | ||
| ] | ||
|
|
||
| install_requirements += matplotlib_version |
There was a problem hiding this comment.
this makes matplotlib an unconditional dependency, which I don't think it was previously
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1000 +/- ##
=======================================
Coverage 54.49% 54.49%
=======================================
Files 210 210
Lines 21560 21560
Branches 3169 3169
=======================================
Hits 11750 11750
Misses 9255 9255
Partials 555 555 |
|
This PR is a bit old, due to lapses on the fault of maintainers for reviewing PRs and merging them. That said, There's a conflict with the main branch that must be resolved. WIthout that resolution soon (next week or so) I'd recommend closing this PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current setup.py does not conform to pep508. Hence it can lead to issues like this.
This PR rewrites the dependencies using pep508