Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Validate sharinpix url #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: Validate sharinpix url #3

wants to merge 7 commits into from

Conversation

kherinwork
Copy link

No description provided.

@kherinwork kherinwork self-assigned this Oct 8, 2018
ombr
ombr requested changes Oct 9, 2018
View reviewed changes
Copy link
Member

@ombr ombr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu peux gérer les code de retours ?
Est-ce que tu peux aussi utiliser du coffee ?

test/commands/auth.test.js Outdated

test
.stdout()
.command(['auth'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour un cli, on s'attend a ce que le code d'exit ne soit pas le même...

@kherinwork kherinwork assigned DJoyekurun and unassigned kherinwork Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ombr ombr ombr requested changes

Assignees

@DJoyekurun DJoyekurun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kherinwork @ombr @DJoyekurun