Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of "Show abbreviation in timetable" to true #1794

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Nov 15, 2024

Since most timetable cells are very small, we often don't enough space to display rooms, teacher, etc. Showing the abbreviations gains more space, since they always only one line. Here the effect:

Before After
3E48F880-F147-4AF0-9DE1-11512806FC53 8A84B5CC-7CFA-4A5B-BCD1-688E2F60D6C0

Related to #110

Copy link

github-actions bot commented Nov 15, 2024

Visit the preview URL for this PR (updated for commit c080a6f):

https://sharezone-console-dev--pr1794-by-default-show-abbr-t3ccpv07.web.app

(expires Mon, 18 Nov 2024 10:18:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6

Copy link

github-actions bot commented Nov 15, 2024

Visit the preview URL for this PR (updated for commit c080a6f):

https://sharezone-website-dev--pr1794-by-default-show-abbr-rcmyq16r.web.app

(expires Mon, 18 Nov 2024 10:18:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

Copy link

github-actions bot commented Nov 15, 2024

Visit the preview URL for this PR (updated for commit c080a6f):

https://sharezone-test--pr1794-by-default-show-abbr-o3my1p5w.web.app

(expires Mon, 18 Nov 2024 10:19:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing labels Nov 15, 2024
@nilsreichardt nilsreichardt added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@nilsreichardt nilsreichardt merged commit b96bad2 into main Nov 16, 2024
37 checks passed
@nilsreichardt nilsreichardt deleted the by-default-show-abbreviation branch November 16, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants