Fix opening keyboard when selecting event/exam time #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature: timetable / calendar
nilsreichardt
commented
Nov 7, 2024
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| if (!_hasRequestedTitleFocus) { | ||
| _hasRequestedTitleFocus = true; | ||
| delayKeyboard(context: context, focusNode: titleFocusNode); |
There was a problem hiding this comment.
@Jonas-Sander Do you know if there was a reason why you called the delayKeyboard in the build() method instead of using a StatefulWidget with initState?
There was a problem hiding this comment.
No, probably just laziness.
|
Visit the preview URL for this PR (updated for commit a9251ae): https://sharezone-test--pr1790-event-fix-keyboard-042z6xgm.web.app (expires Sun, 10 Nov 2024 19:38:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the
delayKeyboard()was calling thebuild()method.Fixes #1789