Enable changing display type of weights (factor or percentage) #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en it doesnt affect the type of the other terms'
github-actions
bot
added
documentation
testing
feature: grades
|
Visit the preview URL for this PR (updated for commit 932b982): https://sharezone-test--pr1712-grade-weights-displa-3o7jbdjb.web.app (expires Sat, 24 Aug 2024 09:22:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
… ${WeightDisplayType.factor} is used'
Sharezone-Admin
approved these changes
Aug 21, 2024
|
Nvm, would need to add the account to code owners. Merging with override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changing the display type of weights (as factor or as percent) in the term settings.
Changing.weight.display.type.webm
The numbers are currently rounded in the weight overview, I'll fix this in another PR.