Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Videokonferenz with Notensystem on Website #1709

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Replace Videokonferenz with Notensystem on Website #1709

merged 7 commits into from
Sep 9, 2024

Conversation

EvilMonkey09
Copy link
Contributor

Fixes #1555

@EvilMonkey09 EvilMonkey09 changed the title Website replace Videokonferenz with Notensystem Replace Videokonferenz with Notensystem on Website Aug 14, 2024
@EvilMonkey09 EvilMonkey09 marked this pull request as ready for review September 9, 2024 13:33
@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a7a4de7):

https://sharezone-website-dev--pr1709-website-replace-vk-w-caywz659.web.app

(expires Thu, 12 Sep 2024 14:24:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@EvilMonkey09 @Jonas-Sander
Remove leaveDefaultPicture
a9ab34f 
Co-authored-by: Jonas Sander <[email protected]>
@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Sep 9, 2024
Jonas-Sander
Jonas-Sander approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like you need to format the dart file again. Also consider merging origin/main into this branch again.

nilsreichardt
nilsreichardt approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilsreichardt nilsreichardt added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Sep 9, 2024
@github-actions github-actions bot removed safe to test Used for fork PRs when the code is safe to test to trigger our CI. labels Sep 9, 2024
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Sep 9, 2024
Merged via the queue into SharezoneApp:main with commit 865fd67 Sep 9, 2024
49 of 50 checks passed
@Jonas-Sander
Copy link
Collaborator

Thanks 🩵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
ui / ux website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "Videokonferenzen" with Grades feature on our website
3 participants
@EvilMonkey09 @Jonas-Sander @nilsreichardt