Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Flutter v3.24.2 #1703

Merged
merged 14 commits into from
Sep 8, 2024
Merged

Upgrade to Flutter v3.24.2 #1703

merged 14 commits into from
Sep 8, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt added the build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. label Aug 11, 2024
@github-actions github-actions bot added feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: notifications Push-Notifications and In-App-Notifications. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: holidays feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. user: teacher feature: report Users can report content inside Sharezone (e.g. if an info sheet contains hate speech). user: parent user: pupil / student dependencies Changing, updating, adding or removing one or more dependencies. feature: feedback Users can send us feedback to improve the app. feature: analytics Includes everything that is related to analytics and usage tracking feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: qr code scanner Includes everything that is related to our qr code scanner package. website labels Aug 11, 2024
@github-actions github-actions bot added ui: light-mode ui: dark-mode w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). feature: grades Users can add their grades to Sharezone. labels Aug 11, 2024
@Sharezone-Admin
Copy link
Member

Sharezone-Admin commented Aug 11, 2024 •
edited
Loading

⬇️ Builds generated by Codemagic for commit c361c84 ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
iOS QR code
Download link		 Android QR code
Download link

(expires Tue, 8 Oct 2024 16:16:45 GMT)
Codemagic build: 66ddcaf25b85eef1c66e766a; comment generated with Codemagic App Preview

@Jonas-Sander
Copy link
Collaborator

Can we hold off until NixOS/nixpkgs#333197 is resolved? Because I tried for an hour to install flutter on my NixOS system and even with the old method of using fvm it doesn't work right now.

@nilsreichardt
Copy link
Member Author

@Jonas-Sander Is this PR ready to merge now since NixOS/nixpkgs#333197 is closed?

@Jonas-Sander Jonas-Sander mentioned this pull request Sep 4, 2024
Merged
@Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Is this PR ready to merge now since NixOS/nixpkgs#333197 is closed?

Well the nix version of flutter is now upgraded, but using this version lead me to this bug: flutter/flutter#153238, which makes it unusable for me. If you want to upgrade, then we could merge the following PR, so that I just use the fvm version again: #1726

github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
@Jonas-Sander
Use fvm in devenv again. (#1726)
4f76401 
Needed for #1703 (or upgrading flutter in general right now), because
using the current nix version of flutter 3.24 lead me to this bug:
flutter/flutter#153238 and I don't want to
block upgrading flutter further, since until the nix version of flutter
is upgraded it will probably take a week or more.
@nilsreichardt nilsreichardt changed the title Upgrade to Flutter v3.24.0 Upgrade to Flutter v3.24.2 Sep 7, 2024
@nilsreichardt
Copy link
Member Author

@Jonas-Sander Can you review the PR?

Jonas-Sander
Jonas-Sander approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander
Copy link
Collaborator

This seems wrong:

image

@nilsreichardt
Copy link
Member Author

This seems wrong:

image

Thanks! Fixed ✅

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 28b529c Sep 8, 2024
38 checks passed
@nilsreichardt nilsreichardt deleted the upgrade-to-flutter-3-24-0 branch September 8, 2024 16:30
@nilsreichardt nilsreichardt mentioned this pull request Oct 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
@nilsreichardt
Upgrade packages with flutter/dart pub upgrade (#1742)
35ec43e 
We couldn't run `dart run build_runner build` anymore. After executing
this command, you received:

```
[SEVERE] Failed to spawn build script after retry. This is likely due to a misconfigured builder definition. See the generated script at .dart_tool/build/entrypoint/build.dart to find errors.
```

This issue was introduced with
#1703. The reason for
it was that we need a newer `frontend_server_client` version (see
google/json_serializable.dart#1427 (comment)).

After running `dart/flutter pub upgrade` in every package, I was able to
execute `dart run build_runner build` again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
admin console build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. dependencies Changing, updating, adding or removing one or more dependencies. feature: analytics Includes everything that is related to analytics and usage tracking feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: feedback Users can send us feedback to improve the app. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: grades Users can add their grades to Sharezone. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: holidays feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: notifications Push-Notifications and In-App-Notifications. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: qr code scanner Includes everything that is related to our qr code scanner package. feature: report Users can report content inside Sharezone (e.g. if an info sheet contains hate speech). feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. platform: android platform: ios platform: macos platform: web testing ui: dark-mode ui: light-mode ui / ux user: parent user: pupil / student user: teacher w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsreichardt @Sharezone-Admin @Jonas-Sander