Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix app to build and deploy app commands #1360

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Mar 4, 2024

Since we are adding more and more different build and deploy commands (like sz deploy website), I added a app prefix for the app commands:

From sz deploy ios to sz deploy app ios (same applies for macos, android and web).

Copy link

github-actions bot commented Mar 4, 2024

Visit the preview URL for this PR (updated for commit 25c9489):

https://sharezone-website-dev--pr1360-rename-build-and-dep-fluyfppx.web.app

(expires Thu, 07 Mar 2024 14:44:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@Jonas-Sander
Copy link
Collaborator

I think I'd prefer sz build app ios. WDYT?

@nilsreichardt nilsreichardt changed the title Add prefix app: to build and deploy app commands Add prefix app to build and deploy app commands Mar 4, 2024
@nilsreichardt
Copy link
Member Author

Build fails because of pull_request_target

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! :)

@nilsreichardt nilsreichardt merged commit 914e38b into main Mar 4, 2024
32 of 33 checks passed
@nilsreichardt nilsreichardt deleted the rename-build-and-deploy-commands branch March 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants