Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --credentials parameter in sz deploy web #1358

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Mar 3, 2024

If you export GOOGLE_APPLICATION_CREDENTIALS, you don't need --credentials anymore.

Tested in https://github.com/SharezoneApp/sharezone-app/actions/runs/8130203967/job/22218181691.

This reverts commit f13d6af.
@nilsreichardt nilsreichardt marked this pull request as ready for review March 3, 2024 12:50
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit 2aa6669 Mar 3, 2024
54 of 55 checks passed
@nilsreichardt nilsreichardt deleted the remove-credentials-parameter branch March 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants