Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting for Markdown files #1335

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Add formatting for Markdown files #1335

merged 2 commits into from
Mar 1, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Feb 29, 2024 •
edited
Loading

Motivation

Since we are adding more and more documentation to https://docs.sharezone.net, it might be helpful to apply the Prettier formatting rules to Markdown files.

Changes

  • Add prettier "**/*.md" --write to sz format command
  • Add top level .prettierignore file for ignoring files to format
  • Apply Prettier formatting for Markdown files

@github-actions github-actions bot added documentation ci/cd code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: ios platform: android feature: groups Groups umbrella term for courses and classes. testing sharezone cli feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: qr code scanner Includes everything that is related to our qr code scanner package. labels Feb 29, 2024
@nilsreichardt nilsreichardt removed feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: ios platform: android feature: groups Groups umbrella term for courses and classes. testing feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: qr code scanner Includes everything that is related to our qr code scanner package. labels Feb 29, 2024
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit f0f1b83 Mar 1, 2024
26 checks passed
@nilsreichardt nilsreichardt deleted the add-formatting-for-markdown-fiels branch March 1, 2024 08:33
@github-actions github-actions bot added feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. labels Mar 1, 2024
@github-actions github-actions bot added platform: ios platform: android feature: groups Groups umbrella term for courses and classes. testing feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: qr code scanner Includes everything that is related to our qr code scanner package. labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
ci/cd code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. documentation feature: groups Groups umbrella term for courses and classes. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: qr code scanner Includes everything that is related to our qr code scanner package. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription platform: android platform: ios sharezone cli testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander