Updated time font size for better readability #1287

gantanikhilraj · 2024-02-03T13:38:48Z

Closes Issue #1275

Adjusted time display font size in AnimatedSwitcher for better visibility across various screen sizes

Before	After

Summary by CodeRabbit

Style
- Updated the display style of time in the homework dialog to adapt to different screen widths.

coderabbitai · 2024-02-03T13:38:57Z

Warning

Rate Limit Exceeded

@nilsreichardt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 47 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9c1a5b1 and 9ac2edf.

Walkthrough

This update enhances the user interface of a homework application by dynamically adjusting the font size of the time displayed in a dialog, based on the screen width of the device. This ensures better readability across different device sizes, providing a more user-friendly experience.

Changes

File Path	Change Summary
`.../homework/homework_dialog.dart`	Updated the `Text` widget to use a `TextStyle` with dynamic font size.

🐰✨
Changes in the code, oh so bright,
Making the app a delightful sight.
For every screen, big or small,
Readability improved for all.
🎉📱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e1a88f3 and 0431a5c.

Files selected for processing (1)

app/lib/homework/homework_dialog/homework_dialog.dart (1 hunks)

coderabbitai · 2024-02-03T13:39:37Z

app/lib/homework/homework_dialog/homework_dialog.dart

+                    child: Text(
+                      time.toString(),
+                      style: TextStyle(
+                        fontSize: MediaQuery.of(context).size.width * 0.04,
+                      ),
+                    ),


The font size for the submission time text is dynamically set based on the screen width. This approach, while ensuring readability across different devices, might lead to excessively large or small text sizes on unusually large or small screens. Consider setting a minimum and maximum font size to maintain usability and aesthetics.

style: TextStyle( - fontSize: MediaQuery.of(context).size.width * 0.04, + fontSize: MediaQuery.of(context).size.width * 0.04.clamp(12.0, 18.0), ),

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

child: Text(

time.toString(),

style: TextStyle(

fontSize: MediaQuery.of(context).size.width * 0.04,

),

),

child: Text(

time.toString(),

style: TextStyle(

fontSize: MediaQuery.of(context).size.width * 0.04.clamp(12.0, 18.0),

),

),

CLAassistant · 2024-02-03T17:26:38Z

All committers have signed the CLA.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0431a5c and 9c1a5b1.

Files selected for processing (1)

app/lib/homework/homework_dialog/homework_dialog.dart (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/lib/homework/homework_dialog/homework_dialog.dart

nilsreichardt

@gantanikhilraj Thanks for your PR :) I think it's enough when we just use TextStyle(size: 14) 👍 Already changed and also added a screenshot to the PR.

nilsreichardt · 2024-02-03T17:49:25Z

@gantanikhilraj Could you also sign the CLA?

gantanikhilraj · 2024-02-03T17:51:43Z

@gantanikhilraj Could you also sign the CLA?

@nilsreichardt , Done !

github-actions · 2024-02-03T18:34:13Z

Visit the preview URL for this PR (updated for commit 9ac2edf):

https://sharezone-test--pr1287-main-66vg28ak.web.app

_{(expires Tue, 06 Feb 2024 18:34:07 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}

Increased the size of the time text

0431a5c

gantanikhilraj requested review from Jonas-Sander and nilsreichardt as code owners February 3, 2024 13:38

github-actions bot added the feature: homework label Feb 3, 2024

coderabbitai bot reviewed Feb 3, 2024

View reviewed changes

gantanikhilraj changed the title ~~Updated time font size for better readability~~ safe-to-test : Updated time font size for better readability Feb 3, 2024

gantanikhilraj changed the title ~~safe-to-test : Updated time font size for better readability~~ Updated time font size for better readability Feb 3, 2024

Use fontSize

9c1a5b1

coderabbitai bot reviewed Feb 3, 2024

View reviewed changes