Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of leave/delete group buttons #1250

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Jan 12, 2024

Before After
image image

Dark Mode

Desktop Mobile
Screenshot 2024-01-12 at 20 57 31 Screenshot 2024-01-12 at 20 57 26

Also refactored the code to avoid code duplication.

@github-actions github-actions bot added ui / ux feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. labels Jan 12, 2024
Copy link

github-actions bot commented Jan 12, 2024

Visit the preview URL for this PR (updated for commit ee4f06f):

https://sharezone-test--pr1250-improve-design-for-g-t3m5l818.web.app

(expires Mon, 15 Jan 2024 22:44:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 13, 2024
Merged via the queue into main with commit 83bdf89 Jan 13, 2024
28 checks passed
@nilsreichardt nilsreichardt deleted the improve-design-for-group-leave-button branch January 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. ui / ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants