Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move firebase_helper.dart to cloud_firestore_helper #1236

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Move firebase_helper.dart to cloud_firestore_helper #1236

merged 3 commits into from
Jan 6, 2024

Conversation

nilsreichardt
Copy link
Member

This PR moves the firebase_helper.dart to its own cloud_firestore_helper package. The cloud_firestore_helper doesn't have a dependency on cloud_firestore. This is required to use the Sharezone Plus widgets on our website without the Firebase dependencies.

@github-actions github-actions bot added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. testing feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. dependencies Changing, updating, adding or removing one or more dependencies. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ee96e9b):

https://sharezone-website-dev--pr1236-cloud-firestore-help-gjbqbsha.web.app

(expires Tue, 09 Jan 2024 18:49:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ee96e9b):

https://sharezone-test--pr1236-cloud-firestore-help-aipr1505.web.app

(expires Tue, 09 Jan 2024 18:50:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 6, 2024
Merged via the queue into main with commit a029659 Jan 6, 2024
28 checks passed
@nilsreichardt nilsreichardt deleted the cloud-firestore-helper branch January 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander