Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flutter_lints to v3 #1213

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Upgrade flutter_lints to v3 #1213

merged 5 commits into from
Jan 6, 2024

Conversation

nilsreichardt
Copy link
Member

Changelog of flutter_lints v3:

  • Updated package:lints dependency to version 3.0.0, with the following changes:
    • added collection_methods_unrelated_type
    • added dangling_library_doc_comments
    • added implicit_call_tearoffs
    • added secure_pubspec_urls
    • added type_literal_in_constant_pattern
    • added unnecessary_to_list_in_spreads
    • added use_string_in_part_of_directives
    • added use_super_parameters
    • removed iterable_contains_unrelated_type
    • removed list_remove_unrelated_type
    • removed no_wildcard_variable_uses
    • removed prefer_equal_for_default_values
    • removed prefer_void_to_null
  • Updates minimum supported SDK version to Flutter 3.10 / Dart 3.0.

Requires #1211.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a64dcce):

https://sharezone-website-dev--pr1213-upgrade-lints-to-3-wjcq4ksy.web.app

(expires Tue, 09 Jan 2024 11:04:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a64dcce):

https://sharezone-test--pr1213-upgrade-lints-to-3-lrisslg2.web.app

(expires Tue, 09 Jan 2024 11:05:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: web platform: ios feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: notifications Push-Notifications and In-App-Notifications. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: holidays feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). testing feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. user: teacher labels Jan 5, 2024
@github-actions github-actions bot added feature: report Users can report content inside Sharezone (e.g. if an info sheet contains hate speech). sharezone cli user: parent feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. user: pupil / student dependencies Changing, updating, adding or removing one or more dependencies. feature: feedback Users can send us feedback to improve the app. feature: analytics Includes everything that is related to analytics and usage tracking feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). feature: qr code scanner Includes everything that is related to our qr code scanner package. website labels Jan 5, 2024
@nilsreichardt
Copy link
Member Author

@Jonas-Sander Could you review this PR?

@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 6, 2024
Merged via the queue into main with commit 8459340 Jan 6, 2024
29 checks passed
@nilsreichardt nilsreichardt deleted the upgrade-lints-to-3 branch January 6, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. feature: analytics Includes everything that is related to analytics and usage tracking feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. feature: feedback Users can send us feedback to improve the app. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: holidays feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: notifications Push-Notifications and In-App-Notifications. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: qr code scanner Includes everything that is related to our qr code scanner package. feature: report Users can report content inside Sharezone (e.g. if an info sheet contains hate speech). feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. platform: ios platform: web sharezone cli testing ui / ux user: parent user: pupil / student user: teacher w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander