Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Dimensions to sharezone_widgets #1193

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Move Dimensions to sharezone_widgets #1193

merged 1 commit into from
Dec 13, 2023

Conversation

nilsreichardt
Copy link
Member

I moved the dimensions.dart class to the sharezone_widgets package. Technically, it's not a widget but it's something that is only used in our UI so I think it's okay to have in ``sharezone_widgets(better ideas are welcome). This removes the direct dependency ofsharezone_utils` in `sharezone_widgets`.

@github-actions github-actions bot added feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. dependencies Changing, updating, adding or removing one or more dependencies. labels Dec 12, 2023
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 2497ef5):

https://sharezone-website-dev--pr1193-move-dimensions-to-s-7si93bpk.web.app

(expires Fri, 15 Dec 2023 22:45:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 2497ef5):

https://sharezone-test--pr1193-move-dimensions-to-s-pdbt5bpz.web.app

(expires Fri, 15 Dec 2023 22:46:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2023
@nilsreichardt nilsreichardt merged commit 6f29145 into main Dec 13, 2023
27 checks passed
@nilsreichardt nilsreichardt deleted the move-dimensions-to-sharezone-widgets branch December 13, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: groups Groups umbrella term for courses and classes. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. ui / ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander