Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add due date selection chips in homework dialog. #1162

Merged
merged 83 commits into from
Dec 9, 2023
Merged

Add due date selection chips in homework dialog. #1162

merged 83 commits into from
Dec 9, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Nov 22, 2023 •
edited
Loading

Add quick selection chips for choosing a due date when creating a homework.

Sharezone.Web-App.-.Google.Chrome.2023-12-07.15-42-08.mp4

@Jonas-Sander Jonas-Sander changed the title Homework dialog lesson date selection chips Add due date selection chips in homework dialog. Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9d6d2e6):

https://sharezone-test--pr1162-homework-dialog-less-45uxhkln.web.app

(expires Tue, 12 Dec 2023 17:05:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added the ci/cd label Dec 7, 2023
Jonas-Sander
Jonas-Sander commented Dec 7, 2023
View reviewed changes
.github/workflows/unsafe_app_ci.yml Outdated
@@ -165,6 +165,7 @@ jobs:
run: |
fvm flutter build web \
--release \
--dart-define DEVELOPMENT_STAGE=ALPHA \
Copy link
Collaborator Author

@Jonas-Sander Jonas-Sander Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT? We need this so that the chips are shown in the preview app for GitHub PRs. We could add another stage like "PREVIEW" but I thought this is enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new stage like "PREVIEW" sounds good 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work...

Hmm, the line looks good 🤔 When it's not working here, I would assume that also wouldn't work in production

@Jonas-Sander Jonas-Sander marked this pull request as ready for review December 7, 2023 15:13
nilsreichardt
nilsreichardt reviewed Dec 7, 2023
View reviewed changes
app/lib/homework/homework_dialog/homework_dialog_bloc.dart Show resolved Hide resolved
.github/workflows/unsafe_app_ci.yml Outdated
@@ -165,6 +165,7 @@ jobs:
run: |
fvm flutter build web \
--release \
--dart-define DEVELOPMENT_STAGE=ALPHA \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new stage like "PREVIEW" sounds good 👍

.github/workflows/unsafe_app_ci.yml Outdated
@@ -165,6 +165,7 @@ jobs:
run: |
fvm flutter build web \
--release \
--dart-define DEVELOPMENT_STAGE=ALPHA \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work...

Hmm, the line looks good 🤔 When it's not working here, I would assume that also wouldn't work in production

nilsreichardt
nilsreichardt approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the ci/cd label Dec 9, 2023
This was referenced Dec 9, 2023
Closed
Closed
@Jonas-Sander
Copy link
Collaborator Author

Jonas-Sander commented Dec 9, 2023 •
edited
Loading

@nilsreichardt I couldn't get the --dart-define DEVELOPMENT_STAGE=ALPHA (or PREVIEW) working in the preview web app, I'll guess we just have to see if the chips are shown in the alpha web app.

Also could you take a look why the "web-preview" job for the website (not web-app) is failing? I can't merge otherwise

Also blocked by #1181

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Visit the preview URL for this PR (updated for commit 9d6d2e6):

https://sharezone-website-dev--pr1162-homework-dialog-less-c5zmla1m.web.app

(expires Tue, 12 Dec 2023 17:05:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit f904a11 Dec 9, 2023
28 checks passed
@Jonas-Sander Jonas-Sander deleted the homework-dialog-lesson-date-selection-chips branch December 9, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
feature: homework feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing ui / ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt