-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency license check to GitHub Actions #1151
Conversation
This reverts commit 1340002.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Unfortunately every new local lib package will have to be added to the licenses_config.yaml manually.)
We can later add a command to our CLI that checks if each package we use is mentioned in licenses_config.yaml
. This command can then be included in our GitHub checks.
This isn't necessary, the pipeline will fail if we don't add it to the file. I just meant that adding it manually still has to be done for each new package (it isn't automated). |
Ah nice, this shouldn't be a big problem 👍 |
Check that all packages we use have licenses that we are allowed / we want to use via
package:license_checker
.(Unfortunately every new local
lib
package will have to be added to thelicenses_config.yaml
manually.)If it fails the output will list all packages with a non-permitted license.
See this example where I removed the
BSD-3-Clause
license frompermittedLicenses
:Closes #23