Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update privacy policy anchor hash algorithm. #1146

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update privacy policy anchor hash algorithm. #1146

merged 2 commits into from
Nov 6, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Nov 3, 2023 •
edited
Loading

We now replace umlaute and diacritics.

Input Old New
1. Einführung 1-einfhrung 1-einfuehrung
abc pokémon abc-pokmon abc-pokemon

Fixes #1145

@github-actions github-actions bot added testing dependencies Changing, updating, adding or removing one or more dependencies. labels Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 393b370):

https://sharezone-test--pr1146-update-anchor-hash-a-9xou73f7.web.app

(expires Thu, 09 Nov 2023 11:22:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

nilsreichardt
nilsreichardt approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Nov 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2023
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Nov 6, 2023
@Jonas-Sander Jonas-Sander removed this pull request from the merge queue due to a manual request Nov 6, 2023
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit c5e7056 Nov 6, 2023
21 checks passed
@Jonas-Sander Jonas-Sander deleted the update-anchor-hash-algo branch November 6, 2023 12:47
@Jonas-Sander Jonas-Sander mentioned this pull request Dec 10, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2023
@Jonas-Sander
Update privacy policy anchor hashes and add tests. (#1192)
ac6bc65 
I didn't update the anchor hashes of the privacy policies after changing
the anchor hash algorithm in #1146.
In this PR I updated the anchor hashes and added a test for checking
that all anchor hashes are up-to-date.

Fixes #1168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use package:diacritic to generate markdown anchor names.
2 participants
@Jonas-Sander @nilsreichardt