Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong section title for homeworks in next month. #1134

Merged

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 25, 2023

The heading "Später" (later) was wrongly shown if the current day is the end of month and the due date for the homework is the start of the next month. This was caused by using date.addDaysWithNoChecking instead of date.addDays.

Fixes #53.

The heading "Später" (later) was wrongly shown if the current day is the end of month and the due date for the homework is the start of the next month. This was caused by using `addDaysWithNoChecking` instead of `addDays`.

Fixes #53.
@Jonas-Sander Jonas-Sander changed the title Fix wrong homework section title for end-of-month. Fix wrong section title for homeworks in next month. Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Visit the preview URL for this PR (updated for commit a398ba7):

https://sharezone-test--pr1134-fix-wrong-section-ti-u4c3juom.web.app

(expires Sat, 28 Oct 2023 17:28:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 25, 2023 17:23
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit ba58026 Oct 25, 2023
21 of 26 checks passed
@Jonas-Sander Jonas-Sander deleted the fix-wrong-section-title-end-of-month-tomorrow-homework branch October 25, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homework for 1st november is shown as "later" instead of "tomorrow" category in homework page on 31st october.
2 participants