Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sz exec command. #1130

Merged
merged 10 commits into from
Oct 22, 2023
Merged

Add sz exec command. #1130

merged 10 commits into from
Oct 22, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 20, 2023 •
edited
Loading

Requires #1131

The sz exec command runs a custom command for all / multiple packages.
E.g. sz exec -- fvm dart fix --apply.

The flags onlyDart and onlyFlutter can be used to run the command only in pure Dart or only Flutter packages.
E.g. sz exec -onlyDart -- fvm dart pub get.

@Jonas-Sander
Add sz exec command.
b88d848 
The `sz exec` command runs a custom command for all / multiple packages.
E.g. `sz exec -- fvm dart fix --apply`.

The flags `onlyDart` and `onlyFlutter` can be used to run the command only in pure Dart or only Flutter packages.
E.g. `sz exec -onlyDart -- fvm dart pub get`.
@github-actions github-actions bot added platform: macos platform: web platform: ios platform: android testing feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. dependencies Changing, updating, adding or removing one or more dependencies. labels Oct 20, 2023
@Jonas-Sander Jonas-Sander mentioned this pull request Oct 20, 2023
Merged
@github-actions github-actions bot removed platform: macos platform: web platform: ios platform: android testing feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. dependencies Changing, updating, adding or removing one or more dependencies. labels Oct 22, 2023
@Jonas-Sander
Copy link
Collaborator Author

@nilsreichardt Can be reviewed now

nilsreichardt
nilsreichardt approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 22, 2023
Merged via the queue into main with commit e2beac1 Oct 22, 2023
20 checks passed
@Jonas-Sander Jonas-Sander deleted the sz-exec-command branch October 22, 2023 17:47
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2023
@Jonas-Sander
Replace dart:io file code with package:file. (#1132)
780288c 
We use `package:file` to create a layer of indirection (`FileSystem`) so
that code can be tested more easily (similar to #1131).
Additionally I created a `Context` class, just so that one doesn't have
to pass many parameters to all `Command` classes.

Requires #1130
Requires #1131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
sharezone cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt