-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add +200 colors for Sharezone Plus users #1033
Conversation
// This is a hack to make sure that the dialog has the same size when | ||
// switching between the two pages. Otherwise the dialog changes its | ||
// size when switching between the two pages which looks weird. | ||
const Opacity( | ||
opacity: 0, | ||
child: IgnorePointer( | ||
child: Stack( | ||
children: [ | ||
_PlusBaseColors(), | ||
_PlusAccurateColors(baseColor: Colors.amber) | ||
], | ||
), | ||
), | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open for better solutions.
Visit the preview URL for this PR (updated for commit f7ec8ea): https://sharezone-test--pr1033-restrict-free-colors-6ukluzmr.web.app (expires Tue, 12 Dec 2023 17:43:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's surprising for the user that a second dialog with a shade selection will come. I might imagine users being surprised after buying Plus and then not having more colors right on the first screen. Just adding "Grundton auswählen" to the top of the first dialog might already help, because then there is an expectation for a second shade selection.
...goldens/groups/src/pages/course/course_edit/design/src/dialog/select_design_dialog_test.dart
Outdated
Show resolved
Hide resolved
Visit the preview URL for this PR (updated for commit f7ec8ea): https://sharezone-website-dev--pr1033-restrict-free-colors-6y26l0xc.web.app (expires Tue, 12 Dec 2023 17:42:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e |
Description
I added a new color picker for Sharezone Plus users. Sharezone Plus users first select a base color and can then select an accurate color. The base colors are just all primaries Google Material colors and the accurate colors are all variants of the base color.
Demo
When a user has Sharezone Plus:
Screen.Recording.2023-09-20.at.00.44.29.mov
When a user has not Sharezone Plus:
Related tickets
Closes #855
Closes #854