Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add +200 colors for Sharezone Plus users #1033

Merged
merged 13 commits into from
Dec 9, 2023
Merged

Conversation

nilsreichardt
Copy link
Member

Description

I added a new color picker for Sharezone Plus users. Sharezone Plus users first select a base color and can then select an accurate color. The base colors are just all primaries Google Material colors and the accurate colors are all variants of the base color.

Demo

When a user has Sharezone Plus:

Screen.Recording.2023-09-20.at.00.44.29.mov

When a user has not Sharezone Plus:

image

Related tickets

Closes #855
Closes #854

@github-actions github-actions bot added feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Sep 19, 2023
Comment on lines +170 to +183
// This is a hack to make sure that the dialog has the same size when
// switching between the two pages. Otherwise the dialog changes its
// size when switching between the two pages which looks weird.
const Opacity(
opacity: 0,
child: IgnorePointer(
child: Stack(
children: [
_PlusBaseColors(),
_PlusAccurateColors(baseColor: Colors.amber)
],
),
),
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open for better solutions.

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Visit the preview URL for this PR (updated for commit f7ec8ea):

https://sharezone-test--pr1033-restrict-free-colors-6ukluzmr.web.app

(expires Tue, 12 Dec 2023 17:43:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's surprising for the user that a second dialog with a shade selection will come. I might imagine users being surprised after buying Plus and then not having more colors right on the first screen. Just adding "Grundton auswählen" to the top of the first dialog might already help, because then there is an expectation for a second shade selection.

@nilsreichardt
Copy link
Member Author

image

I added "Grundfarbe auswählen" for the first dialog ✅

Copy link

github-actions bot commented Dec 9, 2023

Visit the preview URL for this PR (updated for commit f7ec8ea):

https://sharezone-website-dev--pr1033-restrict-free-colors-6y26l0xc.web.app

(expires Tue, 12 Dec 2023 17:42:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit 89bd64a Dec 9, 2023
28 checks passed
@nilsreichardt nilsreichardt deleted the restrict-free-colors branch December 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription testing
Projects
None yet
2 participants