Change HomeworkDialogApi.edit to take HomeworkId instead of `Home…

…workDto oldHomework`.
SharezoneApp · Oct 12, 2023 · 00ab30d · 00ab30d
1 parent 3f4b4e9
commit 00ab30d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/lib/blocs/homework/homework_dialog_bloc.dart b/app/lib/blocs/homework/homework_dialog_bloc.dart
@@ -276,10 +276,10 @@ class HomeworkDialogBloc extends BlocBase {
       final removedCloudFiles = matchRemovedCloudFilesFromTwoList(
           initialCloudFiles, _cloudFilesSubject.valueOrNull!);
       if (hasAttachments) {
-        await api.edit(initialHomework!, userInput,
+        await api.edit(HomeworkId(initialHomework!.id), userInput,
             removedCloudFiles: removedCloudFiles);
       } else {
-        api.edit(initialHomework!, userInput,
+        api.edit(HomeworkId(initialHomework!.id), userInput,
             removedCloudFiles: removedCloudFiles);
       }
 
@@ -443,8 +443,10 @@ class HomeworkDialogApi {
     return homework;
   }
 
-  Future<HomeworkDto> edit(HomeworkDto oldHomework, UserInput userInput,
+  Future<HomeworkDto> edit(HomeworkId homeworkId, UserInput userInput,
       {List<CloudFile> removedCloudFiles = const []}) async {
+    final oldHomework =
+        await _api.homework.singleHomeworkStream(homeworkId.id).first;
     List<String> attachments = oldHomework.attachments.toList();
     final editorName = (await _api.user.userStream.first)!.name;
     final editorID = _api.user.authUser!.uid;

diff --git a/app/test/homework/homework_dialog_test.dart b/app/test/homework/homework_dialog_test.dart
@@ -59,7 +59,7 @@ class MockHomeworkDialogApi implements HomeworkDialogApi {
   late UserInput userInputFromEditing;
   late List<CloudFile> removedCloudFilesFromEditing;
   @override
-  Future<HomeworkDto> edit(HomeworkDto oldHomework, UserInput userInput,
+  Future<HomeworkDto> edit(HomeworkId homeworkId, UserInput userInput,
       {List<CloudFile> removedCloudFiles = const []}) async {
     userInputFromEditing = userInput;
     removedCloudFilesFromEditing = removedCloudFiles;