Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTCChanges #10158

Merged
merged 11 commits into from
Mar 22, 2025
Merged

DTCChanges #10158

merged 11 commits into from
Mar 22, 2025

Conversation

Spucelik
Copy link
Contributor

Category

  • Content fix
  • New article

Merging the admin/billing page into this page and expanding on the pass through instructions.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Learn Build status updates of commit a200190:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/embedded/getting-started/containertypes.md ⚠️Warning View Details
docs/embedded/getting-started/spembedded-for-vscode.md ⚠️Warning View Details
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

docs/embedded/getting-started/containertypes.md

  • Line 27, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Creating Container Types') are not allowed. You can only have one top-level heading.
  • Line 30, Column 5: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#trial-use' in 'embedded/getting-started/containertypes.md'.
  • Line 159, Column 24: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 208, Column 70: [Warning: file-not-found - See documentation] Invalid file link: 'meters.md'.
  • Line 159, Column 24: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps' will be broken in isolated environments. Replace with a relative link.
  • Line 159, Column 24: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps

docs/embedded/getting-started/spembedded-for-vscode.md

  • Line 40, Column 46: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#trial-use' in 'embedded/getting-started/containertypes.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Learn Build status updates of commit 372e3a2:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/embedded/getting-started/containertypes.md ⚠️Warning View Details
docs/embedded/getting-started/spembedded-for-vscode.md ⚠️Warning View Details
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

docs/embedded/getting-started/containertypes.md

  • Line 159, Column 24: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 159, Column 24: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps' will be broken in isolated environments. Replace with a relative link.
  • Line 159, Column 24: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps

docs/embedded/getting-started/spembedded-for-vscode.md

  • Line 40, Column 46: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#trial-use' in 'embedded/getting-started/containertypes.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@andrewconnell andrewconnell self-assigned this Mar 18, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Learn Build status updates of commit e84e1cf:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/embedded/getting-started/register-api-documentation.md ⚠️Warning View Details
docs/embedded/getting-started/spembedded-for-vscode.md ⚠️Warning View Details
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

docs/embedded/getting-started/register-api-documentation.md

  • Line 73, Column 109: [Warning: file-not-found - See documentation] Invalid file link: '../development/auth'.
  • Line 73, Column 187: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-client-creds-grant-flow' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 73, Column 316: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-client-creds-grant-flow#second-case-access-token-request-with-a-certificate' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 73, Column 187: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-client-creds-grant-flow' will be broken in isolated environments. Replace with a relative link.
  • Line 73, Column 316: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-client-creds-grant-flow#second-case-access-token-request-with-a-certificate' will be broken in isolated environments. Replace with a relative link.

docs/embedded/getting-started/spembedded-for-vscode.md

  • Line 40, Column 46: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#trial-use' in 'embedded/getting-started/containertypes.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Learn Build status updates of commit 3c0a5d1:

💡 Validation status: suggestions

File Status Preview URL Details
docs/embedded/getting-started/register-api-documentation.md 💡Suggestion View Details
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/getting-started/spembedded-for-vscode.md ✅Succeeded View
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

docs/embedded/getting-started/register-api-documentation.md

  • Line 81, Column 190: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/v2-oauth2-client-creds-grant-flow' will be broken in isolated environments. Replace with a relative link.
  • Line 81, Column 313: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/v2-oauth2-client-creds-grant-flow#second-case-access-token-request-with-a-certificate' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@andrewconnell
Copy link
Collaborator

andrewconnell commented Mar 20, 2025

I'm going to flip this PR to draft mode as based on the internal discussion/feedback, it doesn't appear ready for review to get merged.

When you're ready to submit it for review & to be merged, please change its status from DRAFT => OPEN.

Also... those absolute link findings in the build report should be fixed prior to submitting it to be merged. Thanks!

@andrewconnell andrewconnell marked this pull request as draft March 20, 2025 06:45
@andrewconnell andrewconnell added the pr:do-not-merge Pull request not ready to be merged label Mar 20, 2025
@Spucelik Spucelik marked this pull request as ready for review March 20, 2025 11:35
@Spucelik Spucelik marked this pull request as draft March 20, 2025 11:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Learn Build status updates of commit 7de90ff:

💡 Validation status: suggestions

File Status Preview URL Details
docs/embedded/getting-started/register-api-documentation.md 💡Suggestion View Details
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/getting-started/spembedded-for-vscode.md ✅Succeeded View
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

docs/embedded/getting-started/register-api-documentation.md

  • Line 81, Column 190: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/v2-oauth2-client-creds-grant-flow' will be broken in isolated environments. Replace with a relative link.
  • Line 81, Column 313: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/v2-oauth2-client-creds-grant-flow#second-case-access-token-request-with-a-certificate' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Spucelik
Copy link
Contributor Author

@dluces ... this should have been the last change. If you agree let's move this out of draft so we can merge it.

Copy link
Contributor

Learn Build status updates of commit 0e2614e:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/getting-started/register-api-documentation.md ✅Succeeded View
docs/embedded/getting-started/spembedded-for-vscode.md ✅Succeeded View
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Spucelik Spucelik marked this pull request as ready for review March 21, 2025 15:25
@andrewconnell andrewconnell removed the pr:do-not-merge Pull request not ready to be merged label Mar 22, 2025
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Mar 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- always use `1.` for numbered bullets; let the markdown rendering engine insert the numbers
- always seperate headings & paragraphs with newlines (not adjacent)
@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Mar 22, 2025
Copy link
Contributor

Learn Build status updates of commit 96928d3:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/getting-started/register-api-documentation.md ✅Succeeded View
docs/embedded/getting-started/spembedded-for-vscode.md ✅Succeeded View
docs/embedded/images/SyntexActivatePAYGSetup.png ✅Succeeded View
docs/embedded/images/SyntexPAYGActivateSPE.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@andrewconnell andrewconnell merged commit f4618bc into SharePoint:main Mar 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge Ready to merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants