Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ARM): exclude ryzenadj if running on non-x86_64 hardware #17

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

ShadowApex
Copy link
Contributor

This change adds conditional compilation settings to exclude ryzenadj if PowerStation is built for non-x86_64 architectures.

@ShadowApex ShadowApex requested a review from pastaq December 30, 2024 08:05
Copy link
Contributor

@pastaq pastaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change as a future proofing measure for ARM, but PowerStation will be entirely useless on anything but x86_64 right now, so I still think there is value is restricting compiling on ARM for now.

@ShadowApex ShadowApex merged commit 4ae9696 into main Jan 2, 2025
2 checks passed
@ShadowApex ShadowApex deleted the shadowapex/arm64-support branch January 2, 2025 23:38
Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 0.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants