fix(AsusWMI): Use both WMI methods #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pastaq
commented
Dec 23, 2024
pastaq
commented
- Revert commit be7c492.
- Remove dangerous unwraps from firmware_attributes usage.
- Use FirmwareAttributes as an Option, add RogPlatform as fallback.
…ibutes" This reverts commit be7c492.
pastaq
force-pushed
the
pastaq/asus-wmi-fix
branch
from
d131fe4 to
1e958e2
Compare
- Remove dangerous unwraps from firmware_attributes usage. - Use FirmwareAttributes as an Option, add RogPlatform as fallback.
pastaq
force-pushed
the
pastaq/asus-wmi-fix
branch
from
1e958e2 to
59c95c4
Compare
ShadowApex
reviewed
Dec 23, 2024
|
Seems to work. I can't set boost to 0 but I think that's an issue with OGUI. OGUI also spams everything 3x when setting things, we should look into that. |
ShadowApex
approved these changes
Dec 24, 2024
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.