Fixed: Silent Failure when GitHub Tag is non-NuGet Version

Sewer56 · Mar 2, 2023 · 9c6c948 · 9c6c948
1 parent 4b8e151
commit 9c6c948
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/Sewer56.Update/Resolvers/Sewer56.Update.Resolvers.GitHub/GitHubReleaseResolver.cs b/Sewer56.Update/Resolvers/Sewer56.Update.Resolvers.GitHub/GitHubReleaseResolver.cs
@@ -75,7 +75,7 @@ public async Task InitializeAsync()
             }
             else
             {
-                _gitHubReleaseForNonTag = releasesEnumerable.OrderBy(x => new NuGetVersion(x.TagName)).Last();
+                _gitHubReleaseForNonTag = releasesEnumerable.OrderByDescending(x => x.PublishedAt).First();
                 _releaseMetadataForNonTag = await TryGetReleaseMetadataAsync(_gitHubReleaseForNonTag);
                 if (_releaseMetadataForNonTag != null)
                     _versions = _releaseMetadataForNonTag.GetNuGetVersionsFromReleaseMetadata(_commonResolverSettings.AllowPrereleases);

diff --git a/...6.Update/Resolvers/Sewer56.Update.Resolvers.GitHub/Sewer56.Update.Resolvers.GitHub.csproj b/...6.Update/Resolvers/Sewer56.Update.Resolvers.GitHub/Sewer56.Update.Resolvers.GitHub.csproj
@@ -12,7 +12,9 @@
     <RepositoryUrl>https://github.com/Sewer56/Update</RepositoryUrl>
     <PackageLicenseExpression>LGPL-3.0-or-later</PackageLicenseExpression>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-    <Version>1.5.0</Version>
+    <Version>1.5.1</Version>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/Sewer56.Update/Sewer56.Update/Sewer56.Update.csproj b/Sewer56.Update/Sewer56.Update/Sewer56.Update.csproj
@@ -19,8 +19,10 @@ This framework is a hard fork of Onova.</Description>
     <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
     <Authors>Sewer56, Tyrrrz</Authors>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-    <Version>4.0.0</Version>
+    <Version>4.0.1</Version>
     <IsTrimmable>true</IsTrimmable>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
   <ItemGroup>